Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of ReactiveHTML resources #2397

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Conversation

philippjfr
Copy link
Member

  • Deduplicate ReactiveHTML resources
  • Add example using external resources

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #2397 (e2b8411) into master (483d000) will decrease coverage by 0.05%.
The diff coverage is 29.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
- Coverage   83.62%   83.56%   -0.06%     
==========================================
  Files         185      185              
  Lines       22601    22619      +18     
==========================================
+ Hits        18899    18901       +2     
- Misses       3702     3718      +16     
Impacted Files Coverage Δ
panel/io/resources.py 75.74% <29.16%> (-5.24%) ⬇️
panel/io/reload.py 64.36% <0.00%> (-2.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483d000...e2b8411. Read the comment docs.

@philippjfr philippjfr merged commit 8b8a7e8 into master Jun 16, 2021
@philippjfr philippjfr deleted the reactive_html_resource branch June 16, 2021 13:58
@nghenzi
Copy link
Contributor

nghenzi commented Jun 18, 2021

Great Work ! This is awesome !!! it will improve a lot the visual aspects of the apps

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants